]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mmc: mtk-sd: disable wakeup in .remove() and in the error path of .probe()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Tue, 3 Dec 2024 02:34:42 +0000 (11:34 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 10 Dec 2024 15:02:34 +0000 (16:02 +0100)
Current implementation leaves pdev->dev as a wakeup source. Add a
device_init_wakeup(&pdev->dev, false) call in the .remove() function and
in the error path of the .probe() function.

Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Fixes: 527f36f5efa4 ("mmc: mediatek: add support for SDIO eint wakup IRQ")
Cc: stable@vger.kernel.org
Message-ID: <20241203023442.2434018-1-joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c

index efb0d2d5716b966e08465ef267f419f0cc569c6d..af445d3f8e2ae7a44514a9899fd16a6434929098 100644 (file)
@@ -3070,6 +3070,7 @@ release_clk:
        msdc_gate_clock(host);
        platform_set_drvdata(pdev, NULL);
 release_mem:
+       device_init_wakeup(&pdev->dev, false);
        if (host->dma.gpd)
                dma_free_coherent(&pdev->dev,
                        2 * sizeof(struct mt_gpdma_desc),
@@ -3103,6 +3104,7 @@ static void msdc_drv_remove(struct platform_device *pdev)
                        host->dma.gpd, host->dma.gpd_addr);
        dma_free_coherent(&pdev->dev, MAX_BD_NUM * sizeof(struct mt_bdma_desc),
                          host->dma.bd, host->dma.bd_addr);
+       device_init_wakeup(&pdev->dev, false);
 }
 
 static void msdc_save_reg(struct msdc_host *host)