mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe()

If devm_of_platform_populate() fails, some clean-up needs to be done, as
already done in the remove function.

Add a new devm_add_action_or_reset() to fix the leak in the probe and
remove the need of a remove function.

Fixes: c695abab2429 ("mfd: Add Samsung Exynos Low Power Audio Subsystem driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/69471e839efc0249a504492a8de3497fcdb6a009.1745247209.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
index a2785ceea8bfcd333564a846c84d4a46df60802d..44797001a4322b4a56d28993e1867232f9e1e491 100644 (file)
--- a/drivers/mfd/exynos-lpass.c
+++ b/drivers/mfd/exynos-lpass.c
@@ -104,11 +104,22 @@ static const struct regmap_config exynos_lpass_reg_conf = {
        .fast_io        = true,
 };
 
+static void exynos_lpass_disable_lpass(void *data)
+{
+       struct platform_device *pdev = data;
+       struct exynos_lpass *lpass = platform_get_drvdata(pdev);
+
+       pm_runtime_disable(&pdev->dev);
+       if (!pm_runtime_status_suspended(&pdev->dev))
+               exynos_lpass_disable(lpass);
+}
+
 static int exynos_lpass_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct exynos_lpass *lpass;
        void __iomem *base_top;
+       int ret;
 
        lpass = devm_kzalloc(dev, sizeof(*lpass), GFP_KERNEL);
        if (!lpass)
@@ -134,16 +145,11 @@ static int exynos_lpass_probe(struct platform_device *pdev)
        pm_runtime_enable(dev);
        exynos_lpass_enable(lpass);
 
-       return devm_of_platform_populate(dev);
-}
-
-static void exynos_lpass_remove(struct platform_device *pdev)
-{
-       struct exynos_lpass *lpass = platform_get_drvdata(pdev);
+       ret = devm_add_action_or_reset(dev, exynos_lpass_disable_lpass, pdev);
+       if (ret)
+               return ret;
 
-       pm_runtime_disable(&pdev->dev);
-       if (!pm_runtime_status_suspended(&pdev->dev))
-               exynos_lpass_disable(lpass);
+       return devm_of_platform_populate(dev);
 }
 
 static int __maybe_unused exynos_lpass_suspend(struct device *dev)
@@ -183,7 +189,6 @@ static struct platform_driver exynos_lpass_driver = {
                .of_match_table = exynos_lpass_of_match,
        },
        .probe  = exynos_lpass_probe,
-       .remove = exynos_lpass_remove,
 };
 module_platform_driver(exynos_lpass_driver);