netfilter: xt_physdev: masks are not c-strings

... and must not be subjected to the 'nul terminated' constraint.
If the interface name is 15 characters long, the mask is 16-bytes
'0xff' (to cover for \0) and the valid device name is rejected.

Fixes: 8df772afc9d0 ("netfilter: x_physdev: reject empty or not-nul terminated device names")
Cc: stable@vger.kernel.org
Closes: https://bugs.launchpad.net/neutron/+bug/2159935
Signed-off-by: Florian Westphal <fw@strlen.de>

diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c
index dd98f758176c2ed13c3aae4f6b3095a96463f034..a388881c68d42bd15171afce25a2d1669f028048 100644 (file)
--- a/net/netfilter/xt_physdev.c
+++ b/net/netfilter/xt_physdev.c
@@ -130,11 +130,6 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)
                if (X(physoutdev))
                        return -ENAMETOOLONG;
        }
-
-       if (X(in_mask))
-               return -ENAMETOOLONG;
-       if (X(out_mask))
-               return -ENAMETOOLONG;
 #undef X
 
        if (!brnf_probed) {