]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (g762) Initialize fans after configuring clock
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Jul 2024 22:41:07 +0000 (15:41 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 9 Jul 2024 22:45:48 +0000 (15:45 -0700)
Adding support for G761 included adding support for an internal clock.
Enabling the internal clock requires setting a bit in the FAN_CMD2
register. This is implemented in g762_fan_init(). However, g762_fan_init()
is called before clock support is selected, and the flag indicating that
the internal clock should be used is not yet set.

Initialize the clock before initializing the fan to solve the problem.
While at it, also add "g7621" to the i2c_device_id array.

Cc: Christian Marangi <ansuelsmth@gmail.com>
Fixes: 6ce402327a6f ("hwmon: g672: add support for g761")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/g762.c

index a00cf3245eec2ff7c6a12ce3a7890eccc42c3d6c..4fa3aa1271daa803ef2a1b448a2368b0866114ca 100644 (file)
@@ -44,6 +44,7 @@
 #define DRVNAME "g762"
 
 static const struct i2c_device_id g762_id[] = {
+       { "g761" },
        { "g762" },
        { "g763" },
        { }
@@ -1083,15 +1084,16 @@ static int g762_probe(struct i2c_client *client)
        data->client = client;
        mutex_init(&data->update_lock);
 
-       /* Enable fan failure detection and fan out of control protection */
-       ret = g762_fan_init(dev);
+       /* Get configuration via DT ... */
+       ret = g762_of_clock_enable(client);
        if (ret)
                return ret;
 
-       /* Get configuration via DT ... */
-       ret = g762_of_clock_enable(client);
+       /* Enable fan failure detection and fan out of control protection */
+       ret = g762_fan_init(dev);
        if (ret)
                return ret;
+
        ret = g762_of_prop_import(client);
        if (ret)
                return ret;