Improvement on the previous check-in. Parse.rc is less reliable than

Parse.nErr for detecting SQLITE_TOOBIG errors.

FossilOrigin-Name: 8d478cfb92fdeb87591403fe1713b290fee309a38b71abee0002012935d1db98

diff --git a/manifest b/manifest
index bac1dda39bc865207653f91d8e82fcc48b7faa5d..e66acdb7bc7dfd3a6da3576d2e29539598f68453 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Early\sdetection\sof\sSQLITE_TOOBIG\swhen\sprocessing\snested\squeries.
-D 2019-04-22T20:05:54.645
+C Improvement\son\sthe\sprevious\scheck-in.\s\sParse.rc\sis\sless\sreliable\sthan\nParse.nErr\sfor\sdetecting\sSQLITE_TOOBIG\serrors.
+D 2019-04-23T12:30:15.974
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -518,7 +518,7 @@ F src/printf.c 67f79227273a9009d86a017619717c3f554f50b371294526da59faa6014ed2cd
 F src/random.c 80f5d666f23feb3e6665a6ce04c7197212a88384
 F src/resolve.c 567888ee3faec14dae06519b4306201771058364a37560186a3e0e755ebc4cb8
 F src/rowset.c d977b011993aaea002cab3e0bb2ce50cf346000dff94e944d547b989f4b1fe93
-F src/select.c e2c1f53e429753699593f3918c465d17b528cbdce3e41db08adcdfa9a19cd9ae
+F src/select.c b7304d2f491c11a03a7fbdf34bc218282ac54052377809d4dc3b4b1e7f4bfc93
 F src/shell.c.in 0d1a1abd8f1056ac6b32981442618e988e1e192cec2e904e58c72fcf494c901e
 F src/sqlite.h.in 38390767acc1914d58930e03149595ee4710afa4e3c43ab6c3a8aea3f1a6b8cd
 F src/sqlite3.rc 5121c9e10c3964d5755191c80dd1180c122fc3a8
@@ -1818,7 +1818,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P b2ce5ed175cb5029ac07392ae371c86eeec23c74624aad007dee51cf359f3eeb
-R 1131fd6ab632cf843fd3481da275126c
+P 5d85d80ef8b216639244c6f4e6a2c0050af3cf9c3998f372bae4a19c0430f2fd
+R 3fe320a5871498cd9f9fa2f114a99352
 U drh
-Z 2b97e19a94f7f535b7b97df584acbe3e
+Z 37b55947258e1ee79a97c65d6538f295

diff --git a/manifest.uuid b/manifest.uuid
index 4e5afda521b64a2ef3f70b539331ebae770f61b6..5a4dc830f1f6691945a98772170a21031dc6adce 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-5d85d80ef8b216639244c6f4e6a2c0050af3cf9c3998f372bae4a19c0430f2fd
\ No newline at end of file
+8d478cfb92fdeb87591403fe1713b290fee309a38b71abee0002012935d1db98
\ No newline at end of file

diff --git a/src/select.c b/src/select.c
index 436e7c1a8dd2a46b93fa175262d1b604606dafbb..2df79e2e6c9063b973afb40a2e055f0e80f287ad 100644 (file)
--- a/src/select.c
+++ b/src/select.c
@@ -4797,7 +4797,7 @@ int sqlite3ExpandSubquery(Parse *pParse, struct SrcList_item *pFrom){
   pTab->nRowLogEst = 200; assert( 200==sqlite3LogEst(1048576) );
   pTab->tabFlags |= TF_Ephemeral;
 
-  return pParse->rc;
+  return pParse->nErr ? SQLITE_ERROR : SQLITE_OK;
 }
 
 /*