]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/gt: Drop third submission for default context
authorLucas De Marchi <lucas.demarchi@intel.com>
Thu, 10 Jul 2025 20:33:51 +0000 (13:33 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 14 Jul 2025 20:40:17 +0000 (13:40 -0700)
There's no need to submit the nop job again on the first queue. Any
state needed is already saved when the first LRC is switched out. The
comment is a little misleading regarding indirect W/A: first of all
there's still no indirect W/A enabled and secondly, even after they are,
there's no need to submit this job again for having their state
propagated: the indirect W/A will actually run on every LRC switch.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20250710-lrc-refactors-v2-6-a5e2ca03f6bd@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_gt.c

index 08be659b9334cf745f2a480f3bb2b7e7780062b5..1cd1b551eb1f298708f48f6228d23181bafd32ff 100644 (file)
@@ -363,14 +363,6 @@ int xe_gt_record_default_lrcs(struct xe_gt *gt)
                        goto put_nop_q;
                }
 
-               /* Reload golden LRC to record the effect of any indirect W/A */
-               err = emit_nop_job(gt, q);
-               if (err) {
-                       xe_gt_err(gt, "hwe %s: emit_nop_job failed (%pe) guc_id=%u\n",
-                                 hwe->name, ERR_PTR(err), q->guc->id);
-                       goto put_nop_q;
-               }
-
                xe_map_memcpy_from(xe, default_lrc,
                                   &q->lrc[0]->bo->vmap,
                                   xe_lrc_pphwsp_offset(q->lrc[0]),