]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
kernel/panic: return early from print_tainted() when not tainted
authorJani Nikula <jani.nikula@intel.com>
Fri, 31 May 2024 09:04:54 +0000 (12:04 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 25 Jun 2024 05:25:04 +0000 (22:25 -0700)
Reduce indent to make follow-up changes slightly easier on the eyes.

Link: https://lkml.kernel.org/r/01d6c03de1c9d1b52b59c652a3704a0a9886ed63.1717146197.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/panic.c

index 8bff183d6180e752a0a7ba0ea9ed1617322fb02a..3edad0c6091dac2bbccff28283b07ee177a77bfe 100644 (file)
@@ -507,22 +507,23 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = {
 const char *print_tainted(void)
 {
        static char buf[TAINT_FLAGS_COUNT + sizeof("Tainted: ")];
+       char *s;
+       int i;
 
        BUILD_BUG_ON(ARRAY_SIZE(taint_flags) != TAINT_FLAGS_COUNT);
 
-       if (tainted_mask) {
-               char *s;
-               int i;
-
-               s = buf + sprintf(buf, "Tainted: ");
-               for (i = 0; i < TAINT_FLAGS_COUNT; i++) {
-                       const struct taint_flag *t = &taint_flags[i];
-                       *s++ = test_bit(i, &tainted_mask) ?
-                                       t->c_true : t->c_false;
-               }
-               *s = 0;
-       } else
+       if (!tainted_mask) {
                snprintf(buf, sizeof(buf), "Not tainted");
+               return buf;
+       }
+
+       s = buf + sprintf(buf, "Tainted: ");
+       for (i = 0; i < TAINT_FLAGS_COUNT; i++) {
+               const struct taint_flag *t = &taint_flags[i];
+               *s++ = test_bit(i, &tainted_mask) ?
+                       t->c_true : t->c_false;
+       }
+       *s = 0;
 
        return buf;
 }