]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ref_tracker: do xarray and workqueue job initializations earlier
authorJeff Layton <jlayton@kernel.org>
Thu, 26 Jun 2025 12:52:14 +0000 (08:52 -0400)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 Jun 2025 20:20:29 +0000 (13:20 -0700)
The kernel test robot reported an oops that occurred when attempting to
deregister a dentry from the xarray during subsys_initcall().

The ref_tracker xarrays and workqueue job are being initialized in
late_initcall() which is too late. Move those to postcore_initcall()
instead.

Fixes: 65b584f53611 ("ref_tracker: automatically register a file in debugfs for a ref_tracker_dir")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202506251406.c28f2adb-lkp@intel.com
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20250626-reftrack-dbgfs-v1-1-812102e2a394@kernel.org
lib/ref_tracker.c

index dcf923a1edf5b7d7342bf61ccec5b54a2eceab5b..a9e6ffcff04b1da162a5a6add6bff075c2c9405e 100644 (file)
@@ -516,13 +516,19 @@ static void debugfs_reap_work(struct work_struct *work)
        } while (reaped);
 }
 
-static int __init ref_tracker_debugfs_init(void)
+static int __init ref_tracker_debugfs_postcore_init(void)
 {
        INIT_WORK(&debugfs_reap_worker, debugfs_reap_work);
        xa_init_flags(&debugfs_dentries, XA_FLAGS_LOCK_IRQ);
        xa_init_flags(&debugfs_symlinks, XA_FLAGS_LOCK_IRQ);
+       return 0;
+}
+postcore_initcall(ref_tracker_debugfs_postcore_init);
+
+static int __init ref_tracker_debugfs_late_init(void)
+{
        ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL);
        return 0;
 }
-late_initcall(ref_tracker_debugfs_init);
+late_initcall(ref_tracker_debugfs_late_init);
 #endif /* CONFIG_DEBUG_FS */