]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
82-test_ocsp_cert_chain.t: kill -HUP the server after client quits
authorTomas Mraz <tomas@openssl.org>
Fri, 22 Mar 2024 15:11:42 +0000 (16:11 +0100)
committerTomas Mraz <tomas@openssl.org>
Mon, 29 Apr 2024 08:25:39 +0000 (10:25 +0200)
This ensures even if the connection for some reason
fails, the server will terminate and the test won't get
stuck.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/23857)

test/recipes/82-test_ocsp_cert_chain.t

index 1328776a145859f55bb207d0c9de76e8491e0c77..a0c3737be89fb1088161ab93bd65f40a4583f489 100644 (file)
@@ -120,6 +120,9 @@ sub run_test {
     my @s_client_cmd = ("s_client", "-connect", "localhost:$server_port", "-status", "-verify_return_error");
     my $s_client_pid = open3(my $s_client_i, my $s_client_o, my $s_client_e = gensym, $shlib_wrap, $apps_openssl, @s_client_cmd);
 
+    waitpid($s_client_pid, 0);
+    kill 'HUP', $s_server_pid, $ocsp_pid;
+
     ### the output from s_server that we want to check is written to its stderr
     ###    cert_status: ocsp response sent:
 
@@ -133,9 +136,6 @@ sub run_test {
         }
     }
     ok($resp == 1, "check s_server sent ocsp response");
-
-    waitpid($s_client_pid, 0);
-    kill 'HUP', $s_server_pid, $ocsp_pid;
 }
 
 run_test();