]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t0020: use ! check_packed_refs_marked
authorDenton Liu <liu.denton@gmail.com>
Fri, 20 Dec 2019 18:15:54 +0000 (10:15 -0800)
committerJunio C Hamano <gitster@pobox.com>
Fri, 20 Dec 2019 19:30:44 +0000 (11:30 -0800)
The test_must_fail function should only be used for git commands since
we should assume that external commands work sanely. Since
check_packed_refs_marked() just wraps a grep invocation, replace
`test_must_fail check_packed_refs_marked` with
`! check_packed_refs_marked`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t1409-avoid-packing-refs.sh

index e5cb8a252dd1a7d8e65eece2fe4ee5e21d748b90..c46848eb8e6bc1121fbdb97be45152db6f1802e3 100755 (executable)
@@ -46,7 +46,7 @@ test_expect_success 'check that marking the packed-refs file works' '
        git for-each-ref >actual &&
        test_cmp expected actual &&
        git pack-refs --all &&
-       test_must_fail check_packed_refs_marked &&
+       ! check_packed_refs_marked &&
        git for-each-ref >actual2 &&
        test_cmp expected actual2
 '
@@ -80,7 +80,7 @@ test_expect_success 'touch packed-refs on delete of packed' '
        git pack-refs --all &&
        mark_packed_refs &&
        git update-ref -d refs/heads/packed-delete &&
-       test_must_fail check_packed_refs_marked
+       ! check_packed_refs_marked
 '
 
 test_expect_success 'leave packed-refs untouched on update of loose' '