Would it be wise to have the plsql.sgml file renamed to plpgsql.sgml?

All of the internal tags are of the latter.

The other thing I noticed is that most of the quick examples in the file
use a para and synopsis.  Is there a reason we're not using <example/> ?

Rod Taylor

diff --git a/doc/src/sgml/filelist.sgml b/doc/src/sgml/filelist.sgml
index d8c5998fb84a1567734b3ce37cae70a0df86eb93..d6fdd71561b6fa7a901a9a4d8c4f24ccb1924b71 100644 (file)
--- a/doc/src/sgml/filelist.sgml
+++ b/doc/src/sgml/filelist.sgml
@@ -1,4 +1,4 @@
-<!-- $Header: /cvsroot/pgsql/doc/src/sgml/filelist.sgml,v 1.19 2002/06/15 02:59:55 thomas Exp $ -->
+<!-- $Header: /cvsroot/pgsql/doc/src/sgml/filelist.sgml,v 1.20 2002/07/30 19:36:10 momjian Exp $ -->
 
 <!entity history    SYSTEM "history.sgml">
 <!entity info       SYSTEM "info.sgml">
@@ -83,7 +83,7 @@
 <!entity xtypes     SYSTEM "xtypes.sgml">
 <!entity plperl     SYSTEM "plperl.sgml">
 <!entity plpython   SYSTEM "plpython.sgml">
-<!entity plsql      SYSTEM "plsql.sgml">
+<!entity plsql      SYSTEM "plpgsql.sgml">
 <!entity pltcl      SYSTEM "pltcl.sgml">
 
 <!-- developer's guide -->

diff --git a/doc/src/sgml/plsql.sgml b/doc/src/sgml/plpgsql.sgml
similarity index 99%
rename from doc/src/sgml/plsql.sgml
rename to doc/src/sgml/plpgsql.sgml
index 082b77fc5b21806418eb955dc28c903719b39d90..9a58e6b8e3b272ceecb95c7beef9aca5eec8e46f 100644 (file)
--- a/doc/src/sgml/plsql.sgml
+++ b/doc/src/sgml/plpgsql.sgml
@@ -1,5 +1,5 @@
 <!--
-$Header: /cvsroot/pgsql/doc/src/sgml/Attic/plsql.sgml,v 2.60 2002/06/24 23:12:06 tgl Exp $
+$Header: /cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v 1.1 2002/07/30 19:36:10 momjian Exp $
 -->
 
 <chapter id="plpgsql"> 
@@ -978,13 +978,15 @@ EXECUTE <replaceable class="command">query-string</replaceable>;
 
     <para>
      An example:
-<synopsis>
+<informalexample>
+<programlisting>
 EXECUTE ''UPDATE tbl SET ''
         || quote_ident(fieldname)
         || '' = ''
         || quote_literal(newvalue)
         || '' WHERE ...'';
-</synopsis>
+</programlisting>
+</informalexample>
     </para>
 
     <para>
@@ -1059,6 +1061,13 @@ GET DIAGNOSTICS <replaceable>variable</replaceable> = <replaceable>item</replace
      <acronym>SQL</acronym> query.  Note that <varname>RESULT_OID</>
      is only useful after an INSERT query.
     </para>
+    <para>
+<informalexample>
+<programlisting>
+      GET DIAGNOSTICS var_integer = ROW_COUNT;
+</programlisting>
+</informalexample>
+    </para>
    </sect2>
   </sect1>