]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done()
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 14:43:45 +0000 (15:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 19 Feb 2025 15:59:24 +0000 (16:59 +0100)
drm_atomic_helper_wait_for_flip_done() will wait for pages flips on all
CRTCs affected by a given commit. It takes the drm_atomic_state being
committed as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-26-e71598f49c8f@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_atomic_helper.c

index c429b0248e81e15a224ae979afed8fb10c1bbbe4..7a25e70694ba2a5ccb28c4f8bd6c43069df75131 100644 (file)
@@ -1728,7 +1728,7 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_vblanks);
 /**
  * drm_atomic_helper_wait_for_flip_done - wait for all page flips to be done
  * @dev: DRM device
- * @old_state: atomic state object with old state structures
+ * @state: atomic state object being committed
  *
  * Helper to, after atomic commit, wait for page flips on all affected
  * crtcs (ie. before cleaning up old framebuffers using
@@ -1741,16 +1741,16 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_vblanks);
  * initialized using drm_atomic_helper_setup_commit().
  */
 void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev,
-                                         struct drm_atomic_state *old_state)
+                                         struct drm_atomic_state *state)
 {
        struct drm_crtc *crtc;
        int i;
 
        for (i = 0; i < dev->mode_config.num_crtc; i++) {
-               struct drm_crtc_commit *commit = old_state->crtcs[i].commit;
+               struct drm_crtc_commit *commit = state->crtcs[i].commit;
                int ret;
 
-               crtc = old_state->crtcs[i].ptr;
+               crtc = state->crtcs[i].ptr;
 
                if (!crtc || !commit)
                        continue;
@@ -1761,8 +1761,8 @@ void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev,
                                crtc->base.id, crtc->name);
        }
 
-       if (old_state->fake_commit)
-               complete_all(&old_state->fake_commit->flip_done);
+       if (state->fake_commit)
+               complete_all(&state->fake_commit->flip_done);
 }
 EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);