]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
usb: gadget: atmel: Add missing null check
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Mon, 29 Sep 2025 16:25:23 +0000 (17:25 +0100)
committerMattijs Korpershoek <mkorpershoek@kernel.org>
Tue, 30 Sep 2025 09:51:17 +0000 (11:51 +0200)
Add in the missing null check for udc->driver that is present at other
points in the function before it is dereferenced.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Reviewed-by: Marek Vasut <marek.vasut@mailbox.org>
Link: https://lore.kernel.org/r/20250929-atmel_usba_udc-v1-1-e1426271e12a@linaro.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
drivers/usb/gadget/atmel_usba_udc.c

index 72f68dba3a741b7f0aac8ba89b83eefb5e0cce4f..f7a92ded6dab187475249874db37d81a07bf5b9e 100644 (file)
@@ -1147,7 +1147,7 @@ static int usba_udc_irq(struct usba_udc *udc)
                reset_all_endpoints(udc);
 
                if (udc->gadget.speed != USB_SPEED_UNKNOWN &&
-                   udc->driver->disconnect) {
+                   udc->driver && udc->driver->disconnect) {
                        udc->gadget.speed = USB_SPEED_UNKNOWN;
                        spin_unlock(&udc->lock);
                        udc->driver->disconnect(&udc->gadget);