Fix segmentation fault on missing squid.conf values

Directves expecting percentage values may segfault when no value token
is supplied.

 Detected by Coverity Scan. Issue 970941

diff --git a/src/Parsing.cc b/src/Parsing.cc
index ab67afa1986f697060575181daac7342c5cb1a3d..2ed440b1f0deceb73cef919582bcb29e1b1ba0db 100644 (file)
--- a/src/Parsing.cc
+++ b/src/Parsing.cc
@@ -191,6 +191,11 @@ GetPercentage(void)
     int p;
     char *token = strtok(NULL, w_space);
 
+    if (!token) {
+        debugs(0, DBG_PARSE_NOTE(DBG_IMPORTANT), "ERROR: A percentage value is missing.");
+        self_destruct();
+    }
+
     //if there is a % in the end of the digits, we remove it and go on.
     char* end = &token[strlen(token)-1];
     if (*end == '%') {