]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Don't set netdev offline in container cleanup
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 2 Oct 2013 10:10:45 +0000 (11:10 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 3 Oct 2013 10:25:20 +0000 (11:25 +0100)
During container cleanup there is a race where the kernel may
have destroyed the veth device before we try to set it offline.
This causes log error messages. Given that we're about to
delete the device entirely, setting it offline is pointless.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/lxc/lxc_process.c

index f92c613293c3584314df4477f2f057625c6271f4..a78784e5c1a18ee0a1afe810aa1d1789140f5860 100644 (file)
@@ -193,7 +193,6 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
         virDomainNetDefPtr iface = vm->def->nets[i];
         vport = virDomainNetGetActualVirtPortProfile(iface);
         if (iface->ifname) {
-            ignore_value(virNetDevSetOnline(iface->ifname, false));
             if (vport &&
                 vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
                 ignore_value(virNetDevOpenvswitchRemovePort(