]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
m68k: atari: Use str_on_off() helper in atari_nvram_proc_read()
authorThorsten Blum <thorsten.blum@linux.dev>
Fri, 6 Dec 2024 11:56:32 +0000 (12:56 +0100)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 8 Jan 2025 17:04:36 +0000 (18:04 +0100)
Remove hard-coded strings by using the str_on_off() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/20241206115634.47332-2-thorsten.blum@linux.dev
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/atari/nvram.c

index 7000d2443aa3880bab5cdc9f804c4760bf73b313..ededc31375c37d81f87b66661ebe122efb789c33 100644 (file)
@@ -16,7 +16,9 @@
 #include <linux/proc_fs.h>
 #include <linux/seq_file.h>
 #include <linux/spinlock.h>
+#include <linux/string_choices.h>
 #include <linux/types.h>
+
 #include <asm/atarihw.h>
 #include <asm/atariints.h>
 
@@ -198,7 +200,7 @@ static void atari_nvram_proc_read(unsigned char *nvram, struct seq_file *seq,
                seq_printf(seq, "0x%02x (undefined)\n", nvram[1]);
 
        seq_printf(seq, "SCSI arbitration : %s\n",
-                  (nvram[16] & 0x80) ? "on" : "off");
+                  str_on_off(nvram[16] & 0x80));
        seq_puts(seq, "SCSI host ID     : ");
        if (nvram[16] & 0x80)
                seq_printf(seq, "%d\n", nvram[16] & 7);
@@ -236,7 +238,7 @@ static void atari_nvram_proc_read(unsigned char *nvram, struct seq_file *seq,
                   vmode & 16 ? "VGA" : "TV", vmode & 32 ? "PAL" : "NTSC");
        seq_printf(seq,
                   "                   %soverscan, compat. mode %s%s\n",
-                  vmode & 64 ? "" : "no ", vmode & 128 ? "on" : "off",
+                  vmode & 64 ? "" : "no ", str_on_off(vmode & 128),
                   vmode & 256 ?
                   (vmode & 16 ? ", line doubling" : ", half screen") : "");
 }