]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firewire: core: non-atomic memory allocation for isochronous event to user client
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Wed, 4 Sep 2024 12:51:53 +0000 (21:51 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Wed, 4 Sep 2024 12:51:53 +0000 (21:51 +0900)
In the former commits, the callback of isochronous context runs on work
process, thus no need to use atomic memory allocation.

This commit replaces GFP_ATOMIC with GCP_KERNEL in the callback for user
client.

Tested-by: Edmund Raile <edmund.raile@protonmail.com>
Link: https://lore.kernel.org/r/20240904125155.461886-5-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/core-cdev.c

index 3ea220d96c3161d01a424f7199dffce7fdf3222a..518eaa073b2be7cbffe14e085d10d39370173752 100644 (file)
@@ -982,7 +982,7 @@ static void iso_callback(struct fw_iso_context *context, u32 cycle,
        struct client *client = data;
        struct iso_interrupt_event *e;
 
-       e = kmalloc(sizeof(*e) + header_length, GFP_ATOMIC);
+       e = kmalloc(sizeof(*e) + header_length, GFP_KERNEL);
        if (e == NULL)
                return;
 
@@ -1001,7 +1001,7 @@ static void iso_mc_callback(struct fw_iso_context *context,
        struct client *client = data;
        struct iso_interrupt_mc_event *e;
 
-       e = kmalloc(sizeof(*e), GFP_ATOMIC);
+       e = kmalloc(sizeof(*e), GFP_KERNEL);
        if (e == NULL)
                return;