Revert "sendf: make failf() use the mvsnprintf() return code"

This reverts commit 74623551f306990e70c7c5515b88972005604a74.

Instead mark the function call with (void). Getting the return code and
using it instead triggered Coverity warning CID 1463596 because
snprintf() can return a negative value...

Closes #5441

diff --git a/lib/sendf.c b/lib/sendf.c
index 92caf7cec95b642d330a220b35415ac9f67b794b..147ecbfa53e10f0ad80d4416d966759db4e22bf9 100644 (file)
--- a/lib/sendf.c
+++ b/lib/sendf.c
@@ -267,7 +267,8 @@ void Curl_failf(struct Curl_easy *data, const char *fmt, ...)
     size_t len;
     char error[CURL_ERROR_SIZE + 2];
     va_start(ap, fmt);
-    len = mvsnprintf(error, CURL_ERROR_SIZE, fmt, ap);
+    (void)mvsnprintf(error, CURL_ERROR_SIZE, fmt, ap);
+    len = strlen(error);
 
     if(data->set.errorbuffer && !data->state.errorbuf) {
       strcpy(data->set.errorbuffer, error);