]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
tests: iptables-test: Simplify execute_cmd() calling
authorPhil Sutter <phil@nwl.cc>
Thu, 29 Sep 2022 12:48:29 +0000 (14:48 +0200)
committerPhil Sutter <phil@nwl.cc>
Sat, 1 Oct 2022 11:39:35 +0000 (13:39 +0200)
Default 'lineno' parameter to zero,

Signed-off-by: Phil Sutter <phil@nwl.cc>
iptables-test.py

index 69c96b79927b540262829c77fae387f95699abbb..25561bc9ba9713854a242c6f5cb3a58a16e0a31a 100755 (executable)
@@ -168,7 +168,7 @@ def run_test(iptables, rule, rule_save, res, filename, lineno, netns):
 
     return delete_rule(iptables, rule, filename, lineno)
 
-def execute_cmd(cmd, filename, lineno):
+def execute_cmd(cmd, filename, lineno = 0):
     '''
     Executes a command, checking for segfaults and returning the command exit
     code.
@@ -264,7 +264,7 @@ def run_test_file(filename, netns):
     total_test_passed = True
 
     if netns:
-        execute_cmd("ip netns add " + netns, filename, 0)
+        execute_cmd("ip netns add " + netns, filename)
 
     for lineno, line in enumerate(f):
         if line[0] == "#" or len(line.strip()) == 0:
@@ -336,7 +336,7 @@ def run_test_file(filename, netns):
             passed += 1
 
     if netns:
-        execute_cmd("ip netns del " + netns, filename, 0)
+        execute_cmd("ip netns del " + netns, filename)
     if total_test_passed:
         print(filename + ": " + maybe_colored('green', "OK", STDOUT_IS_TTY))