]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
of: property: Avoiding using uninitialized variable @imaplen in parse_interrupt_map()
authorZijun Hu <quic_zijuhu@quicinc.com>
Thu, 9 Jan 2025 13:26:57 +0000 (21:26 +0800)
committerRob Herring (Arm) <robh@kernel.org>
Mon, 13 Jan 2025 13:43:48 +0000 (07:43 -0600)
parse_interrupt_map() will use uninitialized variable @imaplen if fails
to get property 'interrupt-map'.

Fix by using the variable after successfully getting the property.

Fixes: e7985f43609c ("of: property: Fix fw_devlink handling of interrupt-map")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20250109-of_core_fix-v4-6-db8a72415b8c@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/property.c

index 519bf9229e613906547b57d8c68e7b8558eff327..9d8b68c72c363acf364c96138eb55f247a094860 100644 (file)
@@ -1391,9 +1391,9 @@ static struct device_node *parse_interrupt_map(struct device_node *np,
        addrcells = of_bus_n_addr_cells(np);
 
        imap = of_get_property(np, "interrupt-map", &imaplen);
-       imaplen /= sizeof(*imap);
        if (!imap)
                return NULL;
+       imaplen /= sizeof(*imap);
 
        imap_end = imap + imaplen;