]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
slab: mark slab->obj_exts allocation failures unconditionally
authorSuren Baghdasaryan <surenb@google.com>
Mon, 15 Sep 2025 20:09:18 +0000 (13:09 -0700)
committerVlastimil Babka <vbabka@suse.cz>
Tue, 16 Sep 2025 12:32:51 +0000 (14:32 +0200)
alloc_slab_obj_exts() should mark failed obj_exts vector allocations
independent on whether the vector is being allocated for a new or an
existing slab. Current implementation skips doing this for existing
slabs. Fix this by marking failed allocations unconditionally.

Fixes: 09c46563ff6d ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations")
Reported-by: Shakeel Butt <shakeel.butt@linux.dev>
Closes: https://lore.kernel.org/all/avhakjldsgczmq356gkwmvfilyvf7o6temvcmtt5lqd4fhp5rk@47gp2ropyixg/
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Cc: stable@vger.kernel.org # v6.10+
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
mm/slub.c

index 674c5036a18a003ee42e0c50b45b565e3a5100b2..b74d65aa32c6bd023813788e7b1f060b74da02aa 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2039,8 +2039,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s,
                           slab_nid(slab));
        if (!vec) {
                /* Mark vectors which failed to allocate */
-               if (new_slab)
-                       mark_failed_objexts_alloc(slab);
+               mark_failed_objexts_alloc(slab);
 
                return -ENOMEM;
        }