]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
sched_ext: Fix stray scx_root usage in task_can_run_on_remote_rq()
authorTejun Heo <tj@kernel.org>
Tue, 23 Sep 2025 19:03:26 +0000 (09:03 -1000)
committerTejun Heo <tj@kernel.org>
Tue, 23 Sep 2025 19:03:26 +0000 (09:03 -1000)
task_can_run_on_remote_rq() takes @sch but it is using scx_root when
incrementing SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, which is inconsistent and
gets in the way of implementing multiple scheduler support. Use @sch
instead. As currently scx_root is the only possible scheduler instance, this
doesn't cause any behavior changes.

Acked-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext.c

index 0f17b715461f18ee0e40277f6248ffb205b33ddc..8769cfdc22e3ace8385fc71c1bc70f2089cf9c23 100644 (file)
@@ -1622,8 +1622,7 @@ static bool task_can_run_on_remote_rq(struct scx_sched *sch,
 
        if (!scx_rq_online(rq)) {
                if (enforce)
-                       __scx_add_event(scx_root,
-                                       SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, 1);
+                       __scx_add_event(sch, SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE, 1);
                return false;
        }