When GROUP BY uses a nondeterministic collation, the planner's
optimization of moving HAVING clauses to WHERE can produce incorrect
query results. The HAVING clause may apply a stricter collation that
distinguishes values the GROUP BY considers equal. Pushing such a
clause to WHERE causes it to filter individual rows before grouping,
potentially eliminating group members and changing aggregate results.
Fix this by detecting collation conflicts before flatten_group_exprs,
while the HAVING clause still contains GROUP Vars (Vars referencing
RTE_GROUP). At that point, each GROUP Var directly carries the GROUP
BY collation as its varcollid, making it straightforward to compare
against the operator's inputcollid. A mismatch where the GROUP BY
collation is nondeterministic means the clause is unsafe to push down.
RowCompareExpr is treated specially, since it carries per-column
inputcollids[] rather than a single inputcollid.
The conflicting clause indices are recorded in a Bitmapset and
consulted during the existing HAVING-to-WHERE loop, so that only
affected clauses are kept in HAVING; other safe clauses in the same
query are still pushed.
Back-patch to v18 only. The fix relies on the RTE_GROUP mechanism
introduced in v18 (commit
247dea89f), which is what lets us identify
grouping expressions and their resolved collations via GROUP Vars on
pre-flatten havingQual. Pre-v18 branches lack that machinery, so a
back-patch there would need a different approach. Given the absence
of field reports of this bug on back branches, the risk of carrying a
different fix on stable branches is not justified.
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: wenhui qiu <qiuwenhuifx@gmail.com>
Discussion: https://postgr.es/m/CAMbWs48Dn2wW6XM94GZsoyMiH42=KgMo+WcobPKuWvGYnWaPOQ@mail.gmail.com
Backpatch-through: 18
* subquery belonging to a set operation */
} standard_qp_extra;
+/*
+ * Context for the find_having_collation_conflicts walker.
+ *
+ * ancestor_collids is a stack of inputcollids contributed by collation-aware
+ * ancestors of the current node. Entries are pushed before recursing into a
+ * node's children and popped afterwards, so the stack reflects exactly the
+ * inputcollids on the current root-to-node path.
+ */
+typedef struct
+{
+ Index group_rtindex;
+ List *ancestor_collids;
+} having_collation_ctx;
+
/* Local functions */
static Node *preprocess_expression(PlannerInfo *root, Node *expr, int kind);
static void preprocess_qual_conditions(PlannerInfo *root, Node *jtnode);
+static Bitmapset *find_having_collation_conflicts(Query *parse,
+ Index group_rtindex);
+static bool having_collation_conflict_walker(Node *node,
+ having_collation_ctx *ctx);
static void grouping_planner(PlannerInfo *root, double tuple_fraction,
SetOperationStmt *setops);
static grouping_sets_data *preprocess_grouping_sets(PlannerInfo *root);
PlannerInfo *root;
List *newWithCheckOptions;
List *newHaving;
+ Bitmapset *havingCollationConflicts;
+ int havingIdx;
bool hasOuterJoins;
bool hasResultRTEs;
RelOptInfo *final_rel;
}
}
+ /*
+ * Before we flatten GROUP Vars, check which HAVING clauses have collation
+ * conflicts. When GROUP BY uses a nondeterministic collation, values
+ * that are "equal" for grouping may be distinguishable under a different
+ * collation. If such a HAVING clause were moved to WHERE, it would
+ * filter individual rows before grouping, potentially eliminating some
+ * members of a group and thereby changing aggregate results.
+ *
+ * We do this check before flatten_group_exprs because we can easily
+ * identify grouping expressions by checking whether a Var references
+ * RTE_GROUP, and such Vars directly carry the GROUP BY collation as their
+ * varcollid. After flattening, these Vars are replaced by the underlying
+ * expressions, and we would have to match expressions in the HAVING
+ * clause back to grouping expressions, which is much more complex.
+ */
+ if (parse->hasGroupRTE)
+ havingCollationConflicts =
+ find_having_collation_conflicts(parse, root->group_rtindex);
+ else
+ havingCollationConflicts = NULL;
+
/*
* Replace any Vars in the subquery's targetlist and havingQual that
* reference GROUP outputs with the underlying grouping expressions.
* but it's okay: it's just an optimization to avoid running pull_varnos
* when there cannot be any Vars in the HAVING clause.)
*
+ * We also cannot do this if the HAVING clause uses a different collation
+ * than the GROUP BY for any grouping expression whose GROUP BY collation
+ * is nondeterministic. This is detected before flatten_group_exprs (see
+ * find_having_collation_conflicts above) and recorded in the
+ * havingCollationConflicts bitmapset. The bitmapset indexes remain valid
+ * here because flatten_group_exprs uses expression_tree_mutator, which
+ * preserves the list length and ordering of havingQual.
+ *
* Also, it may be that the clause is so expensive to execute that we're
* better off doing it only once per group, despite the loss of
* selectivity. This is hard to estimate short of doing the entire
* as Node *.
*/
newHaving = NIL;
+ havingIdx = 0;
foreach(l, (List *) parse->havingQual)
{
Node *havingclause = (Node *) lfirst(l);
if (contain_agg_clause(havingclause) ||
contain_volatile_functions(havingclause) ||
contain_subplans(havingclause) ||
+ bms_is_member(havingIdx, havingCollationConflicts) ||
(parse->groupClause && parse->groupingSets &&
bms_is_member(root->group_rtindex, pull_varnos(root, havingclause))))
{
/* ... and also keep it in HAVING */
newHaving = lappend(newHaving, havingclause);
}
+
+ havingIdx++;
}
parse->havingQual = (Node *) newHaving;
(int) nodeTag(jtnode));
}
+/*
+ * find_having_collation_conflicts
+ * Identify HAVING clauses that must not be moved to WHERE due to collation
+ * mismatches with GROUP BY.
+ *
+ * This must be called before flatten_group_exprs, while the HAVING clause
+ * still contains GROUP Vars (Vars referencing RTE_GROUP). These GROUP Vars
+ * carry the GROUP BY collation as their varcollid. A GROUP Var with a
+ * nondeterministic varcollid conflicts whenever some collation-aware ancestor
+ * on its path applies a different inputcollid: that operator would distinguish
+ * values which the GROUP BY considers equal, so the clause is unsafe to push
+ * to WHERE.
+ *
+ * Returns a Bitmapset of zero-based indexes into the havingQual list for
+ * clauses that have collation conflicts and must stay in HAVING.
+ */
+static Bitmapset *
+find_having_collation_conflicts(Query *parse, Index group_rtindex)
+{
+ Bitmapset *result = NULL;
+ having_collation_ctx ctx;
+ int idx;
+
+ if (parse->havingQual == NULL)
+ return NULL;
+
+ ctx.group_rtindex = group_rtindex;
+ ctx.ancestor_collids = NIL;
+
+ idx = 0;
+ foreach_ptr(Node, clause, (List *) parse->havingQual)
+ {
+ if (having_collation_conflict_walker(clause, &ctx))
+ result = bms_add_member(result, idx);
+ idx++;
+ Assert(ctx.ancestor_collids == NIL);
+ }
+
+ return result;
+}
+
+/*
+ * Walker function for find_having_collation_conflicts.
+ *
+ * Walk the clause top-down, maintaining a stack of inputcollids contributed
+ * by collation-aware ancestors. At each GROUP Var with a nondeterministic
+ * varcollid, the clause has a conflict if any ancestor's inputcollid differs
+ * from the GROUP Var's varcollid. Most collation-aware nodes expose their
+ * inputcollid through exprInputCollation(); RowCompareExpr is the exception,
+ * as it carries one inputcollid per column in inputcollids[], so we descend
+ * into its (largs[i], rargs[i]) pairs explicitly with the matching collation
+ * pushed onto the stack.
+ */
+static bool
+having_collation_conflict_walker(Node *node, having_collation_ctx *ctx)
+{
+ Oid this_collid;
+ bool result;
+
+ if (node == NULL)
+ return false;
+
+ if (IsA(node, Var))
+ {
+ Var *var = (Var *) node;
+
+ /* We should not see any upper-level Vars here */
+ Assert(var->varlevelsup == 0);
+
+ if (var->varno == ctx->group_rtindex &&
+ OidIsValid(var->varcollid) &&
+ !get_collation_isdeterministic(var->varcollid))
+ {
+ foreach_oid(collid, ctx->ancestor_collids)
+ {
+ if (collid != var->varcollid)
+ return true;
+ }
+ }
+ return false;
+ }
+
+ if (IsA(node, RowCompareExpr))
+ {
+ RowCompareExpr *rcexpr = (RowCompareExpr *) node;
+ ListCell *lc_l;
+ ListCell *lc_r;
+ ListCell *lc_c;
+
+ /*
+ * Each column of a row comparison is compared under its own
+ * inputcollids[i]. Walk each (largs[i], rargs[i]) pair with that
+ * collation pushed, so a Var in column i is checked against the
+ * collation that actually applies to it.
+ */
+ forthree(lc_l, rcexpr->largs,
+ lc_r, rcexpr->rargs,
+ lc_c, rcexpr->inputcollids)
+ {
+ Oid collid = lfirst_oid(lc_c);
+ bool found;
+
+ if (OidIsValid(collid))
+ ctx->ancestor_collids = lappend_oid(ctx->ancestor_collids,
+ collid);
+
+ found = having_collation_conflict_walker((Node *) lfirst(lc_l),
+ ctx) ||
+ having_collation_conflict_walker((Node *) lfirst(lc_r),
+ ctx);
+
+ if (OidIsValid(collid))
+ ctx->ancestor_collids =
+ list_delete_last(ctx->ancestor_collids);
+
+ if (found)
+ return true;
+ }
+ return false;
+ }
+
+ this_collid = exprInputCollation(node);
+ if (OidIsValid(this_collid))
+ ctx->ancestor_collids = lappend_oid(ctx->ancestor_collids,
+ this_collid);
+
+ result = expression_tree_walker(node, having_collation_conflict_walker,
+ ctx);
+
+ if (OidIsValid(this_collid))
+ ctx->ancestor_collids = list_delete_last(ctx->ancestor_collids);
+
+ return result;
+}
+
/*
* preprocess_phv_expression
* Do preprocessing on a PlaceHolderVar expression that's been pulled up.
{A,NULL,C,D,E,F,G,H,I}
(1 row)
+-- Test HAVING-to-WHERE pushdown with nondeterministic collations.
+-- When a HAVING clause uses a different collation than the GROUP BY's
+-- nondeterministic collation, it must not be pushed to WHERE, otherwise
+-- aggregate results can change because the stricter filter eliminates rows
+-- before grouping.
+-- Negative: collation conflict, HAVING must not be pushed to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+ QUERY PLAN
+----------------------------------------------------
+ HashAggregate
+ Group Key: x
+ Filter: (x = 'abc'::text COLLATE case_sensitive)
+ -> Seq Scan on test3ci
+(4 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Positive: same collation, safe to push HAVING to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive;
+ QUERY PLAN
+------------------------------------------------------------
+ GroupAggregate
+ -> Seq Scan on test3ci
+ Filter: (x = 'abc'::text COLLATE case_insensitive)
+(3 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Negative: function applied to grouped column with conflicting collation
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_sensitive;
+ QUERY PLAN
+-----------------------------------------------------------
+ HashAggregate
+ Group Key: x
+ Filter: (upper(x) = 'ABC'::text COLLATE case_sensitive)
+ -> Seq Scan on test3ci
+(4 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_sensitive;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Positive: function with same collation as GROUP BY
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_insensitive;
+ QUERY PLAN
+-------------------------------------------------------------------------
+ GroupAggregate
+ Group Key: x
+ -> Sort
+ Sort Key: x COLLATE case_insensitive
+ -> Seq Scan on test3ci
+ Filter: (upper(x) = 'ABC'::text COLLATE case_insensitive)
+(6 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_insensitive;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Negative: inner function has conflicting collation, even though outer
+-- operator's collation matches GROUP BY due to a COLLATE override
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x COLLATE case_sensitive) COLLATE case_insensitive = 'ABC';
+ QUERY PLAN
+----------------------------------------------------
+ HashAggregate
+ Group Key: x
+ Filter: ((upper((x)::text))::text = 'ABC'::text)
+ -> Seq Scan on test3ci
+(4 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x COLLATE case_sensitive) COLLATE case_insensitive = 'ABC';
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Mixed AND: conflicting clause stays in HAVING, safe clause pushed to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive AND length(x) > 1;
+ QUERY PLAN
+----------------------------------------------------
+ HashAggregate
+ Group Key: x
+ Filter: (x = 'abc'::text COLLATE case_sensitive)
+ -> Seq Scan on test3ci
+ Filter: (length(x) > 1)
+(5 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive AND length(x) > 1;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Positive: AND of two safe clauses, both can be pushed
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive AND length(x) > 1;
+ QUERY PLAN
+----------------------------------------------------------------------------------
+ GroupAggregate
+ -> Seq Scan on test3ci
+ Filter: ((x = 'abc'::text COLLATE case_insensitive) AND (length(x) > 1))
+(3 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive AND length(x) > 1;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Negative: OR with a conflicting clause: must stay in HAVING
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive OR x = 'def' COLLATE case_sensitive ORDER BY 1;
+ QUERY PLAN
+--------------------------------------------------------------------------------------------------------
+ Sort
+ Sort Key: x COLLATE case_insensitive
+ -> HashAggregate
+ Group Key: x
+ Filter: ((x = 'abc'::text COLLATE case_sensitive) OR (x = 'def'::text COLLATE case_sensitive))
+ -> Seq Scan on test3ci
+(6 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive OR x = 'def' COLLATE case_sensitive ORDER BY 1;
+ x | count
+-----+-------
+ abc | 2
+ def | 1
+(2 rows)
+
+-- Negative: collation conflict inside a RowCompareExpr
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING ROW(x, 1) < ROW('ABC' COLLATE case_sensitive, 1) ORDER BY 1;
+ QUERY PLAN
+--------------------------------------------------------------------------
+ Sort
+ Sort Key: x COLLATE case_insensitive
+ -> HashAggregate
+ Group Key: x
+ Filter: (ROW(x, 1) < ROW('ABC'::text COLLATE case_sensitive, 1))
+ -> Seq Scan on test3ci
+(6 rows)
+
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING ROW(x, 1) < ROW('ABC' COLLATE case_sensitive, 1) ORDER BY 1;
+ x | count
+-----+-------
+ abc | 2
+(1 row)
+
+-- Positive: conflicting collation but no grouping expression reference
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING current_setting('server_version') = 'abc' COLLATE case_sensitive;
+ QUERY PLAN
+---------------------------------------------------------------------------------------------------------
+ HashAggregate
+ Group Key: x
+ -> Result
+ One-Time Filter: (current_setting('server_version'::text) = 'abc'::text COLLATE case_sensitive)
+ -> Seq Scan on test3ci
+(5 rows)
+
+-- Positive: deterministic collation in GROUP BY: always safe to push, even if
+-- HAVING uses a nondeterministic collation
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+ QUERY PLAN
+----------------------------------------------------------
+ GroupAggregate
+ -> Seq Scan on test3cs
+ Filter: (x = 'abc'::text COLLATE case_sensitive)
+(3 rows)
+
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+ x | count
+-----+-------
+ abc | 1
+(1 row)
+
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_insensitive ORDER BY 1;
+ QUERY PLAN
+------------------------------------------------------------------
+ GroupAggregate
+ Group Key: x
+ -> Sort
+ Sort Key: x COLLATE case_sensitive
+ -> Seq Scan on test3cs
+ Filter: (x = 'abc'::text COLLATE case_insensitive)
+(6 rows)
+
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_insensitive ORDER BY 1;
+ x | count
+-----+-------
+ abc | 1
+ ABC | 1
+(2 rows)
+
-- bpchar
CREATE TABLE test1bpci (x char(3) COLLATE case_insensitive);
CREATE TABLE test2bpci (x char(3) COLLATE case_insensitive);
SELECT string_to_array('ABC,DEF,GHI' COLLATE case_insensitive, ',', 'abc');
SELECT string_to_array('ABCDEFGHI' COLLATE case_insensitive, NULL, 'b');
+-- Test HAVING-to-WHERE pushdown with nondeterministic collations.
+-- When a HAVING clause uses a different collation than the GROUP BY's
+-- nondeterministic collation, it must not be pushed to WHERE, otherwise
+-- aggregate results can change because the stricter filter eliminates rows
+-- before grouping.
+
+-- Negative: collation conflict, HAVING must not be pushed to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+
+-- Positive: same collation, safe to push HAVING to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive;
+
+-- Negative: function applied to grouped column with conflicting collation
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_sensitive;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_sensitive;
+
+-- Positive: function with same collation as GROUP BY
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_insensitive;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x) = 'ABC' COLLATE case_insensitive;
+
+-- Negative: inner function has conflicting collation, even though outer
+-- operator's collation matches GROUP BY due to a COLLATE override
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x COLLATE case_sensitive) COLLATE case_insensitive = 'ABC';
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING upper(x COLLATE case_sensitive) COLLATE case_insensitive = 'ABC';
+
+-- Mixed AND: conflicting clause stays in HAVING, safe clause pushed to WHERE
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive AND length(x) > 1;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive AND length(x) > 1;
+
+-- Positive: AND of two safe clauses, both can be pushed
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive AND length(x) > 1;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_insensitive AND length(x) > 1;
+
+-- Negative: OR with a conflicting clause: must stay in HAVING
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive OR x = 'def' COLLATE case_sensitive ORDER BY 1;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING x = 'abc' COLLATE case_sensitive OR x = 'def' COLLATE case_sensitive ORDER BY 1;
+
+-- Negative: collation conflict inside a RowCompareExpr
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING ROW(x, 1) < ROW('ABC' COLLATE case_sensitive, 1) ORDER BY 1;
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING ROW(x, 1) < ROW('ABC' COLLATE case_sensitive, 1) ORDER BY 1;
+
+-- Positive: conflicting collation but no grouping expression reference
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3ci GROUP BY x HAVING current_setting('server_version') = 'abc' COLLATE case_sensitive;
+
+-- Positive: deterministic collation in GROUP BY: always safe to push, even if
+-- HAVING uses a nondeterministic collation
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_sensitive;
+
+EXPLAIN (COSTS OFF)
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_insensitive ORDER BY 1;
+SELECT x, count(*) FROM test3cs GROUP BY x HAVING x = 'abc' COLLATE case_insensitive ORDER BY 1;
+
-- bpchar
CREATE TABLE test1bpci (x char(3) COLLATE case_insensitive);
CREATE TABLE test2bpci (x char(3) COLLATE case_insensitive);
gss_name_t
gtrgm_consistent_cache
gzFile
+having_collation_ctx
heap_page_items_state
help_handler
hlCheck