]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
[pre-commit] Require pre-commit version 3.2.0
authorTom de Vries <tdevries@suse.de>
Tue, 4 Feb 2025 21:07:22 +0000 (22:07 +0100)
committerTom de Vries <tdevries@suse.de>
Tue, 4 Feb 2025 21:07:22 +0000 (22:07 +0100)
Recent commit 0bd340d6704 ("pre-commit autoupdate") bumped the isort version
to 6.0.0.

Subsequently, I started running into:
...
$ SKIP=flake8,isort pre-commit run
An error has occurred: InvalidManifestError:
==> File /home/vries/.cache/pre-commit/repommstqefj/.pre-commit-hooks.yaml
==> At Hook(id='isort')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, \
  post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, \
  push but got: 'pre-commit'
Check the log at /home/vries/.cache/pre-commit/pre-commit.log
...

I found a similar PR [1], that explains that using pre-commit as a stage (as
isort 6.0.0 does) is supported starting pre-commit 3.2.0.

Add minimum_pre_commit_version 3.2.0 in .pre-commit-config.yaml, as suggested
in the PR.

After adding this, I get a more helpful message:
...
$ SKIP=flake8,isort pre-commit run
An error has occurred: InvalidConfigError:
==> File .pre-commit-config.yaml
==> At Config()
==> At key: minimum_pre_commit_version
=====> pre-commit version 3.2.0 is required but version 2.17.0 is installed. \
  Perhaps run `pip install --upgrade pre-commit`.
Check the log at /home/vries/.cache/pre-commit/pre-commit.log
...
and after doing so which upgrades pre-commit to version 4.1.0, as well as
re-installing pre-commit using:
...
$ pre-commit uninstall
$ pre-commit install
...
I have a functional setup again.

Interestingly, since pre-commit 4.1.0 runs in a python 3.11 environment, I no
longer need to skip flake8 and isort, as I needed to previously when the
system python 3.6 was used.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
[1] https://github.com/psf/black/issues/4065

.pre-commit-config.yaml

index eed31d7d54bba9af4627203f00fe1748a0a3ad40..be3ee8255754a25f586f48e94434e99e19529e47 100644 (file)
@@ -37,6 +37,7 @@
 # See https://pre-commit.com for more information
 # See https://pre-commit.com/hooks.html for more hooks
 
+minimum_pre_commit_version: 3.2.0
 repos:
   - repo: https://github.com/psf/black-pre-commit-mirror
     rev: 25.1.0