]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: handle memory alloc failure from damon_test_aggregate()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:19:58 +0000 (11:19 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:31 +0000 (17:28 -0800)
damon_test_aggregate() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-5-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index 6e8a605277a314f8071162d825cbf748a8038000..fd1e1ecaa2c911300a4640aabc433975548a6310 100644 (file)
@@ -97,8 +97,15 @@ static void damon_test_aggregate(struct kunit *test)
        struct damon_region *r;
        int it, ir;
 
+       if (!ctx)
+               kunit_skip(test, "ctx alloc fail");
+
        for (it = 0; it < 3; it++) {
                t = damon_new_target();
+               if (!t) {
+                       damon_destroy_ctx(ctx);
+                       kunit_skip(test, "target alloc fail");
+               }
                damon_add_target(ctx, t);
        }
 
@@ -106,6 +113,10 @@ static void damon_test_aggregate(struct kunit *test)
        damon_for_each_target(t, ctx) {
                for (ir = 0; ir < 3; ir++) {
                        r = damon_new_region(saddr[it][ir], eaddr[it][ir]);
+                       if (!r) {
+                               damon_destroy_ctx(ctx);
+                               kunit_skip(test, "region alloc fail");
+                       }
                        r->nr_accesses = accesses[it][ir];
                        r->nr_accesses_bp = accesses[it][ir] * 10000;
                        damon_add_region(r, t);