* libltdl/ltdl.c (parse_dotla_file): If we run out of memory,

do not close the .la file twice.
Coverity report CID 440 via Jeff Squyres.

diff --git a/ChangeLog b/ChangeLog
index 9a35e48c97fe670533c067cf2c2a55d5052409a0..5670dfc56607ce0c376f490168ca58157f364897 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2007-08-30  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 
+       * libltdl/ltdl.c (parse_dotla_file): If we run out of memory,
+       do not close the .la file twice.
+       Coverity report CID 440 via Jeff Squyres.
+
        * libltdl/ltdl.c (has_library_ext): Remove dead code.
        Coverity report CID 561 against Open MPI via Jeff Squyres.
 

diff --git a/libltdl/ltdl.c b/libltdl/ltdl.c
index b1c3228a01414f0b24c2b21220b949883c8ebf8d..08027dbba019c31e38a1cb509386fc5af9f7ffb4 100644 (file)
--- a/libltdl/ltdl.c
+++ b/libltdl/ltdl.c
@@ -1031,7 +1031,6 @@ parse_dotla_file(FILE *file, char **dlname, char **libdir, char **deplibs,
          line = REALLOC (char, line, line_len *2);
          if (!line)
            {
-             fclose (file);
              ++errors;
              goto cleanup;
            }