]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx412: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:51 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./i2c/imx412.c:931:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx412.c

index 7bbd639a9ddfa7fa76d3a4594be1e1c4d002c98a..b3826f80354703b17b416dc233854da3f5736e38 100644 (file)
@@ -927,8 +927,8 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
        imx412->reset_gpio = devm_gpiod_get_optional(imx412->dev, "reset",
                                                     GPIOD_OUT_LOW);
        if (IS_ERR(imx412->reset_gpio)) {
-               dev_err(imx412->dev, "failed to get reset gpio %ld\n",
-                       PTR_ERR(imx412->reset_gpio));
+               dev_err(imx412->dev, "failed to get reset gpio %pe\n",
+                       imx412->reset_gpio);
                return PTR_ERR(imx412->reset_gpio);
        }