drm/i915/dp: Fix AUX IO power enabling for eDP PSR

Panel Self Refresh on eDP requires the AUX IO power to be enabled
whenever the output (main link) is enabled. This is required by the
AUX_PHY_WAKE/ML_PHY_LOCK signaling initiated by the HW automatically to
re-enable the main link after it got disabled in power saving states
(see eDP v1.4b, sections 5.1, 6.1.3.3.1.1).

The Panel Replay mode on non-eDP outputs on the other hand is only
supported by keeping the main link active, thus not requiring the above
AUX_PHY_WAKE/ML_PHY_LOCK signaling (eDP v1.4b, section 6.1.3.3.1.2).
Thus enabling the AUX IO power for this case is not required either.

Based on the above enable the AUX IO power only for eDP/PSR outputs.

Bspec: 49274, 53370

v2:
- Add a TODO comment to adjust the requirement for AUX IO based on
  whether the ALPM/main-link off mode gets enabled. (Rodrigo)

Cc: Animesh Manna <animesh.manna@intel.com>
Fixes: b8cf5b5d266e ("drm/i915/panelreplay: Initializaton and compute config for panel replay")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240910111847.2995725-1-imre.deak@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 00fbe9f8c03a94f4ac33519d6a45c3011c6dce73..b1c294236cc878c034b02976bf31e86b0a29e694 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -916,7 +916,7 @@ intel_ddi_main_link_aux_domain(struct intel_digital_port *dig_port,
         * instead of a specific AUX_IO_<port> reference without powering up any
         * extra wells.
         */
-       if (intel_encoder_can_psr(&dig_port->base))
+       if (intel_psr_needs_aux_io_power(&dig_port->base, crtc_state))
                return intel_display_power_aux_io_domain(i915, dig_port->aux_ch);
        else if (DISPLAY_VER(i915) < 14 &&
                 (intel_crtc_has_dp_encoder(crtc_state) ||

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 1a4ef231a53ca3076fc558a3c24d585982363b1a..4f29ac32ff85bc16d926130673ebcc5e2b176f81 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -205,6 +205,25 @@ bool intel_encoder_can_psr(struct intel_encoder *encoder)
                return false;
 }
 
+bool intel_psr_needs_aux_io_power(struct intel_encoder *encoder,
+                                 const struct intel_crtc_state *crtc_state)
+{
+       /*
+        * For PSR/PR modes only eDP requires the AUX IO power to be enabled whenever
+        * the output is enabled. For non-eDP outputs the main link is always
+        * on, hence it doesn't require the HW initiated AUX wake-up signaling used
+        * for eDP.
+        *
+        * TODO:
+        * - Consider leaving AUX IO disabled for eDP / PR as well, in case
+        *   the ALPM with main-link off mode is not enabled.
+        * - Leave AUX IO enabled for DP / PR, once support for ALPM with
+        *   main-link off mode is added for it and this mode gets enabled.
+        */
+       return intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
+              intel_encoder_can_psr(encoder);
+}
+
 static bool psr_global_enabled(struct intel_dp *intel_dp)
 {
        struct intel_display *display = to_intel_display(intel_dp);

diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
index 4e09c10908e4c65c74285b3d10be64816a4ce6fe..6eb5f15f674faa4d9a75dd23aaa852a0ce076e51 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_psr.h
+++ b/drivers/gpu/drm/i915/display/intel_psr.h
@@ -25,6 +25,8 @@ struct intel_plane_state;
                                    (intel_dp)->psr.source_panel_replay_support)
 
 bool intel_encoder_can_psr(struct intel_encoder *encoder);
+bool intel_psr_needs_aux_io_power(struct intel_encoder *encoder,
+                                 const struct intel_crtc_state *crtc_state);
 void intel_psr_init_dpcd(struct intel_dp *intel_dp);
 void intel_psr_enable_sink(struct intel_dp *intel_dp,
                           const struct intel_crtc_state *crtc_state);