Avoid Comm::Connection leaks when helpers are reconfigured or otherwise closed.

CBDATA_CLASS2 classes must be deleted using C++ delete, not cbdataFree().
cbdataFree() does not call the class destructor.

diff --git a/src/helper.cc b/src/helper.cc
index 9f0268d26e01b2f65184c0075451aeff86ddca99..bd238197ee9c3f1db88596ffa0d5c13614813b23 100644 (file)
--- a/src/helper.cc
+++ b/src/helper.cc
@@ -771,7 +771,7 @@ helperServerFree(helper_server *srv)
     safe_free(srv->requests);
 
     cbdataReferenceDone(srv->parent);
-    cbdataFree(srv);
+    delete srv;
 }
 
 static void
@@ -840,7 +840,7 @@ helperStatefulServerFree(helper_stateful_server *srv)
 
     cbdataReferenceDone(srv->parent);
 
-    cbdataFree(srv);
+    delete srv;
 }
 
 /// Calls back with a pointer to the buffer with the helper output