]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/olpc: Remove redundant null pointer checks in olpc_ec_setup_debugfs()
authorLi Zetao <lizetao1@huawei.com>
Sat, 7 Sep 2024 03:09:59 +0000 (11:09 +0800)
committerHans de Goede <hdegoede@redhat.com>
Wed, 11 Sep 2024 12:20:01 +0000 (14:20 +0200)
Since the debugfs_create_dir() never returns a null pointer, checking
the return value for a null pointer is redundant. Since
debugfs_create_file() can deal with a ERR_PTR() style pointer, drop
the check.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Link: https://lore.kernel.org/r/20240907031009.3591057-2-lizetao1@huawei.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/olpc/olpc-ec.c

index 921520475ff68f9b290aeaee338dcdaa22cab4b2..48e9861bb571f154555dba344979743a9ca95c85 100644 (file)
@@ -332,9 +332,6 @@ static struct dentry *olpc_ec_setup_debugfs(void)
        struct dentry *dbgfs_dir;
 
        dbgfs_dir = debugfs_create_dir("olpc-ec", NULL);
-       if (IS_ERR_OR_NULL(dbgfs_dir))
-               return NULL;
-
        debugfs_create_file("cmd", 0600, dbgfs_dir, NULL, &ec_dbgfs_ops);
 
        return dbgfs_dir;