]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMigrationSrcIsSafeDisk: Check also data file properties for migrability
authorPeter Krempa <pkrempa@redhat.com>
Tue, 9 Sep 2025 13:43:52 +0000 (15:43 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 23 Sep 2025 16:57:00 +0000 (18:57 +0200)
If the qcow2 data file feature (which separates the data into a separate
file from the metadata) is in use the migration safety check ought to
consider both the metadata and the data file for safe migration.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_migration.c

index ae26f74f8cba4783a412438484e6e67d72bbe4e1..2e52e73f486b9ab3e129451c848fbf6cafd115c7 100644 (file)
@@ -1795,6 +1795,12 @@ qemuMigrationSrcIsSafeDisk(virDomainDiskDef *disk,
                                                  &requires_safe_cache) < 0)
         return false;
 
+    if (disk->src->dataFileStore &&
+        qemuMigrationSrcCheckStorageSourceSafety(disk->src->dataFileStore,
+                                                 cfg, &unsafe_storage,
+                                                 &requires_safe_cache) < 0)
+        return false;
+
     if (unsafe_storage) {
         virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                        _("Migration without shared storage is unsafe"));