]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
MySQL reconnection memleak fix.
authorTimo Sirainen <tss@iki.fi>
Fri, 23 Jul 2004 03:23:18 +0000 (06:23 +0300)
committerTimo Sirainen <tss@iki.fi>
Fri, 23 Jul 2004 03:23:18 +0000 (06:23 +0300)
--HG--
branch : HEAD

src/auth/db-mysql.c

index 647455f3f2254e2eafa0e5f95a5448dc0a3d9220..70cbd1e3d98d50f35374fbce3048f3efd1dae842 100644 (file)
@@ -97,21 +97,19 @@ static int mysql_conn_open(struct mysql_connection *conn)
                        i_error("MySQL: mysql_init failed");
                        return FALSE;
                }
+       }
 
-               if (!mysql_real_connect(conn->mysql, conn->set.db_host,
-                                       conn->set.db_user, conn->set.db_passwd,
-                                       conn->set.db,
-                                       conn->set.db_port,
-                                       conn->set.db_unix_socket,
-                                       conn->set.db_client_flags)) {
-                       i_error("MySQL: Can't connect to database %s: %s",
-                               conn->set.db, mysql_error(conn->mysql));
-                       conn->connected = FALSE;
-                       conn->mysql = NULL;
-               } else {
-                       conn->connected = TRUE;
-                       i_info("MySQL: connected to %s", conn->set.db_host);
-               }
+       if (mysql_real_connect(conn->mysql, conn->set.db_host,
+                              conn->set.db_user, conn->set.db_passwd,
+                              conn->set.db,
+                              conn->set.db_port,
+                              conn->set.db_unix_socket,
+                              conn->set.db_client_flags) == NULL) {
+               i_error("MySQL: Can't connect to database %s: %s",
+                       conn->set.db, mysql_error(conn->mysql));
+       } else {
+               conn->connected = TRUE;
+               i_info("MySQL: connected to %s", conn->set.db_host);
        }
        
        return conn->connected;