]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 4 Feb 2026 20:21:49 +0000 (21:21 +0100)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Mar 2026 01:25:09 +0000 (21:25 -0400)
Clang compiler is not happy about set but unused variable
(when dprintk() is no-op):

.../blocklayout/blocklayout.c:384:9: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable]

Remove a leftover from the previous cleanup.

Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write handling in bl_write_pagelist")
Acked-by: Anna Schumaker <anna.schumkaer@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfs/blocklayout/blocklayout.c

index cb0a645aeb501654f9716e8a6efb6878767fa327..94e85ad9067e5e17e5343a6140386b9d6b0e2143 100644 (file)
@@ -381,14 +381,13 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
        sector_t isect, extent_length = 0;
        struct parallel_io *par = NULL;
        loff_t offset = header->args.offset;
-       size_t count = header->args.count;
        struct page **pages = header->args.pages;
        int pg_index = header->args.pgbase >> PAGE_SHIFT;
        unsigned int pg_len;
        struct blk_plug plug;
        int i;
 
-       dprintk("%s enter, %zu@%lld\n", __func__, count, offset);
+       dprintk("%s enter, %u@%lld\n", __func__, header->args.count, offset);
 
        /* At this point, header->page_aray is a (sequential) list of nfs_pages.
         * We want to write each, and if there is an error set pnfs_error
@@ -429,7 +428,6 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
                }
 
                offset += pg_len;
-               count -= pg_len;
                isect += (pg_len >> SECTOR_SHIFT);
                extent_length -= (pg_len >> SECTOR_SHIFT);
        }