PCI: j721e: Fix programming sequence of "strap" settings

The Cadence PCIe Controller integrated in the TI K3 SoCs supports both
Root-Complex and Endpoint modes of operation. The Glue Layer allows
"strapping" the Mode of operation of the Controller, the Link Speed
and the Link Width. This is enabled by programming the "PCIEn_CTRL"
register (n corresponds to the PCIe instance) within the CTRL_MMR
memory-mapped register space. The "reset-values" of the registers are
also different depending on the mode of operation.

Since the PCIe Controller latches onto the "reset-values" immediately
after being powered on, if the Glue Layer configuration is not done while
the PCIe Controller is off, it will result in the PCIe Controller latching
onto the wrong "reset-values". In practice, this will show up as a wrong
representation of the PCIe Controller's capability structures in the PCIe
Configuration Space. Some such capabilities which are supported by the PCIe
Controller in the Root-Complex mode but are incorrectly latched onto as
being unsupported are:
- Link Bandwidth Notification
- Alternate Routing ID (ARI) Forwarding Support
- Next capability offset within Advanced Error Reporting (AER) capability

Fix this by powering off the PCIe Controller before programming the "strap"
settings and powering it on after that. The runtime PM APIs namely
pm_runtime_put_sync() and pm_runtime_get_sync() will decrement and
increment the usage counter respectively, causing GENPD to power off and
power on the PCIe Controller.

Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250908120828.1471776-1-s-vadapalli@ti.com

diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index cfca13a4c840715eab6ca444f319dc9f260df287..5a9ae33e2b9375f2a5fb6ce971027d76f407dc9c 100644 (file)
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -284,6 +284,25 @@ static int j721e_pcie_ctrl_init(struct j721e_pcie *pcie)
        if (!ret)
                offset = args.args[0];
 
+       /*
+        * The PCIe Controller's registers have different "reset-values"
+        * depending on the "strap" settings programmed into the PCIEn_CTRL
+        * register within the CTRL_MMR memory-mapped register space.
+        * The registers latch onto a "reset-value" based on the "strap"
+        * settings sampled after the PCIe Controller is powered on.
+        * To ensure that the "reset-values" are sampled accurately, power
+        * off the PCIe Controller before programming the "strap" settings
+        * and power it on after that. The runtime PM APIs namely
+        * pm_runtime_put_sync() and pm_runtime_get_sync() will decrement and
+        * increment the usage counter respectively, causing GENPD to power off
+        * and power on the PCIe Controller.
+        */
+       ret = pm_runtime_put_sync(dev);
+       if (ret < 0) {
+               dev_err(dev, "Failed to power off PCIe Controller\n");
+               return ret;
+       }
+
        ret = j721e_pcie_set_mode(pcie, syscon, offset);
        if (ret < 0) {
                dev_err(dev, "Failed to set pci mode\n");
@@ -302,6 +321,12 @@ static int j721e_pcie_ctrl_init(struct j721e_pcie *pcie)
                return ret;
        }
 
+       ret = pm_runtime_get_sync(dev);
+       if (ret < 0) {
+               dev_err(dev, "Failed to power on PCIe Controller\n");
+               return ret;
+       }
+
        /* Enable ACSPCIE refclk output if the optional property exists */
        syscon = syscon_regmap_lookup_by_phandle_optional(node,
                                                "ti,syscon-acspcie-proxy-ctrl");