]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: ccs: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:46 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR()

This patch fixes this cocci report:
./i2c/ccs/ccs-core.c:3241:3-10: WARNING: Consider using %pe to print PTR_ERR()
./i2c/ccs/ccs-core.c:3298:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index 1c889c878abd3aeb1b7a887cff29b5eb864ab057..f8523140784c7120eaf018ffa9e3b43ea12ef72f 100644 (file)
@@ -3237,8 +3237,8 @@ static int ccs_probe(struct i2c_client *client)
                dev_info(&client->dev, "no clock defined, continuing...\n");
                sensor->ext_clk = NULL;
        } else if (IS_ERR(sensor->ext_clk)) {
-               dev_err(&client->dev, "could not get clock (%ld)\n",
-                       PTR_ERR(sensor->ext_clk));
+               dev_err(&client->dev, "could not get clock (%pe)\n",
+                       sensor->ext_clk);
                return -EPROBE_DEFER;
        }
 
@@ -3294,8 +3294,8 @@ static int ccs_probe(struct i2c_client *client)
 
        sensor->regmap = devm_cci_regmap_init_i2c(client, 16);
        if (IS_ERR(sensor->regmap)) {
-               dev_err(&client->dev, "can't initialise CCI (%ld)\n",
-                       PTR_ERR(sensor->regmap));
+               dev_err(&client->dev, "can't initialise CCI (%pe)\n",
+                       sensor->regmap);
                return PTR_ERR(sensor->regmap);
        }