]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: ublk: kublk: fix an error log line
authorUday Shankar <ushankar@purestorage.com>
Tue, 1 Apr 2025 20:49:09 +0000 (14:49 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 1 Apr 2025 20:52:38 +0000 (14:52 -0600)
When doing io_uring operations using liburing, errno is not used to
indicate errors, so the %m format specifier does not provide any
relevant information for failed io_uring commands. Fix a log line
emitted on get_params failure to translate the error code returned in
the cqe->res field instead.

Signed-off-by: Uday Shankar <ushankar@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250401-ublk_selftests-v1-2-98129c9bc8bb@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
tools/testing/selftests/ublk/kublk.c

index d39f166c9dc31721381184fb27d68347ecab81b6..91c282bc767449a418cce7fc816dc8e9fc732d6a 100644 (file)
@@ -215,7 +215,7 @@ static void ublk_ctrl_dump(struct ublk_dev *dev)
 
        ret = ublk_ctrl_get_params(dev, &p);
        if (ret < 0) {
-               ublk_err("failed to get params %m\n");
+               ublk_err("failed to get params %d %s\n", ret, strerror(-ret));
                return;
        }