]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: remove unneeded NULL checks before kfree
authorzhong jiang <zhongjiang@huawei.com>
Mon, 13 Aug 2018 06:06:08 +0000 (14:06 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 15 Oct 2018 15:23:26 +0000 (17:23 +0200)
Kfree has taken the NULL pointer into account. So remove the check
before kfree.

The issue is detected with the help of Coccinelle.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/free-space-cache.c

index 0adf38b00fa0477f7a36d2570246213b9442ab23..ed097ff023e839e907e620a8be899fcb91d91072 100644 (file)
@@ -2110,8 +2110,7 @@ new_bitmap:
 
 out:
        if (info) {
-               if (info->bitmap)
-                       kfree(info->bitmap);
+               kfree(info->bitmap);
                kmem_cache_free(btrfs_free_space_cachep, info);
        }
 
@@ -3601,8 +3600,7 @@ again:
 
        if (info)
                kmem_cache_free(btrfs_free_space_cachep, info);
-       if (map)
-               kfree(map);
+       kfree(map);
        return 0;
 }