]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix const checking of enum discriminants
authorOwen Avery <powerboat9.gamer@gmail.com>
Sat, 5 Apr 2025 21:20:44 +0000 (17:20 -0400)
committerCohenArthur <arthur.cohen@embecosm.com>
Mon, 14 Apr 2025 09:29:40 +0000 (09:29 +0000)
gcc/rust/ChangeLog:

* checks/errors/rust-const-checker.cc
(ConstChecker::visit): Visit the enum items of enums.
* resolve/rust-ast-resolve-item.cc
(ResolveItem::visit): Resolve enum discriminants during nr1.0.

gcc/testsuite/ChangeLog:

* rust/compile/enum_discriminant2.rs: New test.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
gcc/rust/checks/errors/rust-const-checker.cc
gcc/rust/resolve/rust-ast-resolve-item.cc
gcc/testsuite/rust/compile/enum_discriminant2.rs [new file with mode: 0644]

index 80b63982c12ddde673cd06c87b04103f03b56b85..81594c00beb490858c16b961c22107b63f58ef54 100644 (file)
@@ -646,6 +646,9 @@ ConstChecker::visit (Enum &enum_item)
 {
   check_default_const_generics (enum_item.get_generic_params (),
                                ConstGenericCtx::Enum);
+
+  for (auto &item : enum_item.get_variants ())
+    item->accept_vis (*this);
 }
 
 void
index 89cf0f3c07e3bf7690f7f7e39037b2415244fb6b..fc226cf28c0a5c9dc4f95f99631192384acc4cf2 100644 (file)
@@ -356,6 +356,8 @@ ResolveItem::visit (AST::EnumItemDiscriminant &item)
   auto cpath = canonical_prefix.append (decl);
 
   mappings.insert_canonical_path (item.get_node_id (), cpath);
+
+  ResolveExpr::go (item.get_expr (), path, cpath);
 }
 
 void
diff --git a/gcc/testsuite/rust/compile/enum_discriminant2.rs b/gcc/testsuite/rust/compile/enum_discriminant2.rs
new file mode 100644 (file)
index 0000000..351dfbb
--- /dev/null
@@ -0,0 +1,9 @@
+fn test() -> isize {
+    1
+}
+
+enum Foo {
+    Bar = test() // { dg-error "only functions marked as .const." }
+}
+
+fn main() {}