wifi: iwlwifi: mvm: log error for failures after D3

We only logged an error in the fast resume path. However, as the
hardware is being restarted it makes sense to log an error to make it
easier to understand what is happening.

Add a new error message into the normal resume path and update the
error in the fast resume path to match.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241226174257.df1e451d4928.Ibe286bc010ad7fecebba5650097e16ed22a654e4@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
index 7d973546c9fb85258c342ddc2a085177e2861ed0..d4cdd638ffe55e0407160b8d83b2cd2ab842652e 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
@@ -3541,6 +3541,7 @@ static int __iwl_mvm_resume(struct iwl_mvm *mvm, bool test)
        iwl_fw_dbg_read_d3_debug_data(&mvm->fwrt);
 
        if (iwl_mvm_check_rt_status(mvm, vif)) {
+               IWL_ERR(mvm, "FW Error occurred during suspend. Restarting.\n");
                set_bit(STATUS_FW_ERROR, &mvm->trans->status);
                iwl_mvm_dump_nic_error_log(mvm);
                iwl_dbg_tlv_time_point(&mvm->fwrt,
@@ -3713,8 +3714,7 @@ int iwl_mvm_fast_resume(struct iwl_mvm *mvm)
        iwl_fw_dbg_read_d3_debug_data(&mvm->fwrt);
 
        if (iwl_mvm_check_rt_status(mvm, NULL)) {
-               IWL_ERR(mvm,
-                       "iwl_mvm_check_rt_status failed, device is gone during suspend\n");
+               IWL_ERR(mvm, "FW Error occurred during suspend. Restarting.\n");
                set_bit(STATUS_FW_ERROR, &mvm->trans->status);
                iwl_mvm_dump_nic_error_log(mvm);
                iwl_dbg_tlv_time_point(&mvm->fwrt,