]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment
authorTudor Ambarus <tudor.ambarus@linaro.org>
Tue, 29 Oct 2024 08:00:49 +0000 (08:00 +0000)
committerTudor Ambarus <tudor.ambarus@linaro.org>
Mon, 11 Nov 2024 10:26:04 +0000 (12:26 +0200)
Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression")
upstream fixed a regression for flavors of 0xef4018 flash that don't
define SFDP tables. Add a comment on the flash definition highlighting
that there are flavors of flashes with and without SFDP support.
It spares developers searching the entire git log for when we'll better
handle these cases.

Acked-by: Pratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20241029080049.96679-1-tudor.ambarus@linaro.org
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
drivers/mtd/spi-nor/winbond.c

index 9f7ce5763e7104a5db9c503ffb41d45b5d393598..8d0a00d69e1233988876a15479d73c5fe899c542 100644 (file)
@@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = {
                .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
        }, {
                .id = SNOR_ID(0xef, 0x40, 0x18),
+               /* Flavors w/ and w/o SFDP. */
                .name = "w25q128",
                .size = SZ_16M,
                .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,