cpufreq/amd-pstate: Drop ret variable from amd_pstate_set_energy_pref_index()

The ret variable is not necessary.

Reviewed-and-tested-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241209185248.16301-14-mario.limonciello@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 419790e52d910e1a0a1bdb694b581e272a730a69..4d665d9c76d3523e385a9787aa9081629aa3fec8 100644 (file)
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -319,13 +319,11 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp)
 static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
                int pref_index)
 {
-       int epp = -EINVAL;
-       int ret;
+       int epp;
 
        if (!pref_index)
                epp = cpudata->epp_default;
-
-       if (epp == -EINVAL)
+       else
                epp = epp_values[pref_index];
 
        if (epp > 0 && cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) {
@@ -341,9 +339,7 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
                                          cpudata->boost_state);
        }
 
-       ret = amd_pstate_set_epp(cpudata, epp);
-
-       return ret;
+       return amd_pstate_set_epp(cpudata, epp);
 }
 
 static inline int msr_cppc_enable(bool enable)