]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: bcm: bcm53573: fix OF node leak in init
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 26 Aug 2024 06:58:01 +0000 (08:58 +0200)
committerStephen Boyd <sboyd@kernel.org>
Wed, 28 Aug 2024 18:54:22 +0000 (11:54 -0700)
Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
leak by accessing parent directly, instead of of_get_parent().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/bcm/clk-bcm53573-ilp.c

index 84f2af736ee8a6645fd2cb57406795f82c08b77e..83ef41d618be37b8f621ef873b2d264367d9379a 100644 (file)
@@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np)
                goto err_free_ilp;
        }
 
-       ilp->regmap = syscon_node_to_regmap(of_get_parent(np));
+       ilp->regmap = syscon_node_to_regmap(np->parent);
        if (IS_ERR(ilp->regmap)) {
                err = PTR_ERR(ilp->regmap);
                goto err_free_ilp;