]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: tegra: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 18:37:53 +0000 (20:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2019 11:40:25 +0000 (13:40 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Wei Ni <wni@nvidia.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: linux-pm@vger.kernel.org
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thermal/tegra/soctherm.c

index fcf70a3728b60451ce5153baa039f16c2b8d3943..43941eb734eb097492ede7daa1357653fab52216 100644 (file)
@@ -1485,23 +1485,13 @@ DEFINE_SHOW_ATTRIBUTE(regs);
 static void soctherm_debug_init(struct platform_device *pdev)
 {
        struct tegra_soctherm *tegra = platform_get_drvdata(pdev);
-       struct dentry *root, *file;
+       struct dentry *root;
 
        root = debugfs_create_dir("soctherm", NULL);
-       if (!root) {
-               dev_err(&pdev->dev, "failed to create debugfs directory\n");
-               return;
-       }
 
        tegra->debugfs_dir = root;
 
-       file = debugfs_create_file("reg_contents", 0644, root,
-                                  pdev, &regs_fops);
-       if (!file) {
-               dev_err(&pdev->dev, "failed to create debugfs file\n");
-               debugfs_remove_recursive(tegra->debugfs_dir);
-               tegra->debugfs_dir = NULL;
-       }
+       debugfs_create_file("reg_contents", 0644, root, pdev, &regs_fops);
 }
 #else
 static inline void soctherm_debug_init(struct platform_device *pdev) {}