]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: atm: fix skb leak in sigd_send() default branch
authorWei Yang <albinwyang@tencent.com>
Sat, 9 May 2026 12:23:58 +0000 (20:23 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 May 2026 01:07:02 +0000 (18:07 -0700)
The default branch in sigd_send() calls sock_put() and returns -EINVAL
without freeing the skb, while all other exit paths do so. Add the
missing dev_kfree_skb() before sock_put() to fix the leak.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Wei Yang <albinwyang@tencent.com>
Link: https://patch.msgid.link/20260509122358.1102997-1-albin_yang@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/atm/signaling.c

index 358fbe5e4d1d069469ba53ed6976e5786cba363a..b991d937205af354cb1d37bb04909e892936362a 100644 (file)
@@ -179,6 +179,7 @@ as_indicate_complete:
                break;
        default:
                pr_alert("bad message type %d\n", (int)msg->type);
+               dev_kfree_skb(skb);
                /* Paired with find_get_vcc(msg->vcc) above */
                sock_put(sk);
                return -EINVAL;