]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov9640: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:31 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:26 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov9640.c

index 01dbc0ba89c878da190e082ebb2fbfc9f0f975cf..2190c52b143326d1537bf70bad3fba1cdd2345d5 100644 (file)
@@ -718,9 +718,10 @@ static int ov9640_probe(struct i2c_client *client)
 
        priv->subdev.ctrl_handler = &priv->hdl;
 
-       priv->clk = devm_clk_get(&client->dev, "mclk");
+       priv->clk = devm_v4l2_sensor_clk_get(&client->dev, "mclk");
        if (IS_ERR(priv->clk)) {
-               ret = PTR_ERR(priv->clk);
+               ret = dev_err_probe(&client->dev, PTR_ERR(priv->clk),
+                                   "failed to get mclk\n");
                goto ectrlinit;
        }