]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: sit: Do not set .ndo_get_stats64
authorBreno Leitao <leitao@debian.org>
Wed, 28 Feb 2024 11:31:22 +0000 (03:31 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 Feb 2024 11:50:13 +0000 (12:50 +0100)
If the driver is using the network core allocation mechanism, by setting
NETDEV_PCPU_STAT_TSTATS, as this driver is, then, it doesn't need to set
the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Since
the network core calls it automatically, and .ndo_get_stats64 should
only be set if the driver needs special treatment.

This simplifies the driver, since all the generic statistics is now
handled by core.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/sit.c

index 5ad01480854d222329fc2f9a9042fce684b3c4d1..655c9b1a19b89e36b30ec91e3e7a9140704d7d73 100644 (file)
@@ -1398,7 +1398,6 @@ static const struct net_device_ops ipip6_netdev_ops = {
        .ndo_uninit     = ipip6_tunnel_uninit,
        .ndo_start_xmit = sit_tunnel_xmit,
        .ndo_siocdevprivate = ipip6_tunnel_siocdevprivate,
-       .ndo_get_stats64 = dev_get_tstats64,
        .ndo_get_iflink = ip_tunnel_get_iflink,
        .ndo_tunnel_ctl = ipip6_tunnel_ctl,
 };