netconsole: move netpoll_parse_ip_addr() earlier for reuse

Move netpoll_parse_ip_addr() earlier in the file to be reused in
other functions, such as local_ip_store(). This avoids duplicate
address parsing logic and centralizes validation for both IPv4
and IPv6 string input.

No functional changes intended.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250811-netconsole_ref-v4-1-9c510d8713a2@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index e3722de08ea9f08b95df2249686e231ad44a8b35..8d1b93264e0fdb94488acf48f0335e2870059453 100644 (file)
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -300,6 +300,26 @@ static void netconsole_print_banner(struct netpoll *np)
        np_info(np, "remote ethernet address %pM\n", np->remote_mac);
 }
 
+static int netpoll_parse_ip_addr(const char *str, union inet_addr *addr)
+{
+       const char *end;
+
+       if (!strchr(str, ':') &&
+           in4_pton(str, -1, (void *)addr, -1, &end) > 0) {
+               if (!*end)
+                       return 0;
+       }
+       if (in6_pton(str, -1, addr->in6.s6_addr, -1, &end) > 0) {
+#if IS_ENABLED(CONFIG_IPV6)
+               if (!*end)
+                       return 1;
+#else
+               return -1;
+#endif
+       }
+       return -1;
+}
+
 #ifdef CONFIG_NETCONSOLE_DYNAMIC
 
 /*
@@ -1742,26 +1762,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
        spin_unlock_irqrestore(&target_list_lock, flags);
 }
 
-static int netpoll_parse_ip_addr(const char *str, union inet_addr *addr)
-{
-       const char *end;
-
-       if (!strchr(str, ':') &&
-           in4_pton(str, -1, (void *)addr, -1, &end) > 0) {
-               if (!*end)
-                       return 0;
-       }
-       if (in6_pton(str, -1, addr->in6.s6_addr, -1, &end) > 0) {
-#if IS_ENABLED(CONFIG_IPV6)
-               if (!*end)
-                       return 1;
-#else
-               return -1;
-#endif
-       }
-       return -1;
-}
-
 static int netconsole_parser_cmdline(struct netpoll *np, char *opt)
 {
        bool ipversion_set = false;