]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/hns: Fix warning storm caused by invalid input in IO path
authorChengchang Tang <tangchengchang@huawei.com>
Fri, 20 Dec 2024 05:52:48 +0000 (13:52 +0800)
committerLeon Romanovsky <leon@kernel.org>
Mon, 23 Dec 2024 14:58:30 +0000 (09:58 -0500)
WARN_ON() is called in the IO path. And it could lead to a warning
storm. Use WARN_ON_ONCE() instead of WARN_ON().

Fixes: 12542f1de179 ("RDMA/hns: Refactor process about opcode in post_send()")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
Link: https://patch.msgid.link/20241220055249.146943-4-huangjunxian6@hisilicon.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 6dddadb90e02600f4f8d6ba65ebc4b8611fc4063..d0469d27c63cbdc0df6d1e3c57ae63665f7dcfbb 100644 (file)
@@ -468,7 +468,7 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
        valid_num_sge = calc_wr_sge_num(wr, &msg_len);
 
        ret = set_ud_opcode(ud_sq_wqe, wr);
-       if (WARN_ON(ret))
+       if (WARN_ON_ONCE(ret))
                return ret;
 
        ud_sq_wqe->msg_len = cpu_to_le32(msg_len);
@@ -572,7 +572,7 @@ static inline int set_rc_wqe(struct hns_roce_qp *qp,
        rc_sq_wqe->msg_len = cpu_to_le32(msg_len);
 
        ret = set_rc_opcode(hr_dev, rc_sq_wqe, wr);
-       if (WARN_ON(ret))
+       if (WARN_ON_ONCE(ret))
                return ret;
 
        hr_reg_write(rc_sq_wqe, RC_SEND_WQE_SO,