]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
libxfs: print the device name if flush-on-close fails
authorDarrick J. Wong <djwong@kernel.org>
Wed, 17 Apr 2024 23:16:50 +0000 (16:16 -0700)
committerCarlos Maiolino <cem@kernel.org>
Tue, 23 Apr 2024 13:16:05 +0000 (15:16 +0200)
Print the name of the device if persisting the write cache fails.
Printing a pointer does not help the user at all, and this causes the
32-bit build to complain:

init.c: In function ‘libxfs_device_close’:
init.c:178:35: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  178 |                         progname, (long long)dev, ret);
      |                                   ^
cc1: all warnings being treated as errors

Fixes: fc83c7574b1f ("libxfs: split out a libxfs_dev structure from struct libxfs_init")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
libxfs/init.c

index 1e035c48f57fef48eedc23ccb25145d723aad799..6ac9d682490a12ad4a0dfc1f84a6aa6f23583faf 100644 (file)
@@ -171,8 +171,8 @@ libxfs_device_close(
        if (ret) {
                ret = -errno;
                fprintf(stderr,
-       _("%s: flush of device %lld failed, err=%d"),
-                       progname, (long long)dev, ret);
+       _("%s: flush of device %s failed, err=%d"),
+                       progname, dev->name, ret);
        }
        close(dev->fd);