]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: pcf2127: fix SPI command byte for PCF2131
authorElena Popa <elena.popa@nxp.com>
Fri, 30 May 2025 10:40:00 +0000 (13:40 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 24 Jun 2025 14:04:42 +0000 (16:04 +0200)
PCF2131 was not responding to read/write operations using SPI. PCF2131
has a different command byte definition, compared to PCF2127/29. Added
the new command byte definition when PCF2131 is detected.

Fixes: afc505bf9039 ("rtc: pcf2127: add support for PCF2131 RTC")
Cc: stable@vger.kernel.org
Signed-off-by: Elena Popa <elena.popa@nxp.com>
Acked-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20250530104001.957977-1-elena.popa@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pcf2127.c

index 31c7dca8f4692cf22fdb61e358afe7687d5a9020..2c7917bc2a31edd298e2fed93596747b7e93e43f 100644 (file)
@@ -1538,6 +1538,11 @@ static int pcf2127_spi_probe(struct spi_device *spi)
                variant = &pcf21xx_cfg[type];
        }
 
+       if (variant->type == PCF2131) {
+               config.read_flag_mask = 0x0;
+               config.write_flag_mask = 0x0;
+       }
+
        config.max_register = variant->max_register,
 
        regmap = devm_regmap_init_spi(spi, &config);